Skip to content

Add grace period to code-mode yield timeouts - #33867

Merged
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/403f587e07e2cde88c86424e46b0eff96ac8c409
Jul 17, 2026
Merged

Add grace period to code-mode yield timeouts#33867
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/403f587e07e2cde88c86424e46b0eff96ac8c409

Conversation

@copyberry

@copyberry copyberry Bot commented Jul 17, 2026

Copy link
Copy Markdown

Add grace period to code-mode yield timeouts

Why

Nested tool calls can finish just after a long code-mode yield deadline, causing
an exec or wait response to yield instead of returning the completed result.

What changed

  • Add a one-second grace period to exec and wait yield timeouts of at least
    ten seconds.
  • Preserve the exact requested timeout for shorter yields.

Testing

Add paused-time coverage for the timeout threshold and for nested tools that
complete during the grace period in both exec and wait.

## Why

Nested tool calls can finish just after a long code-mode yield deadline, causing
an `exec` or `wait` response to yield instead of returning the completed result.

## What changed

- Add a one-second grace period to `exec` and `wait` yield timeouts of at least
  ten seconds.
- Preserve the exact requested timeout for shorter yields.

## Testing

Add paused-time coverage for the timeout threshold and for nested tools that
complete during the grace period in both `exec` and `wait`.

GitOrigin-RevId: 403f587e07e2cde88c86424e46b0eff96ac8c409
@copyberry
copyberry Bot force-pushed the copyberry/codex-internal-to-codex-oss/403f587e07e2cde88c86424e46b0eff96ac8c409 branch from ed5601d to 1b025cb Compare July 17, 2026 16:25
@copyberry
copyberry Bot merged commit 1b025cb into main Jul 17, 2026
14 of 32 checks passed
@copyberry
copyberry Bot deleted the copyberry/codex-internal-to-codex-oss/403f587e07e2cde88c86424e46b0eff96ac8c409 branch July 17, 2026 16:26
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 17, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant