Isolate core tests from shell and rollout persistence - #33858
Merged
copyberry[bot] merged 1 commit intoJul 17, 2026
Merged
Conversation
## Why The shared core test harness does not need to spawn a login shell for every test, and approval scenarios exercise tool behavior rather than rollout persistence. ## What changed - Disable `ShellSnapshot` by default in `test_codex()`; snapshot-specific tests can continue to opt in explicitly. - Give each approval scenario a named in-memory thread store so it does not use durable rollout storage. GitOrigin-RevId: 787670857aa4f77d5fc442ec1e0bfe6d22314f63
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/787670857aa4f77d5fc442ec1e0bfe6d22314f63
branch
from
July 17, 2026 15:59
a30ed49 to
41ad08c
Compare
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/787670857aa4f77d5fc442ec1e0bfe6d22314f63
branch
July 17, 2026 16:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Isolate core tests from shell and rollout persistence
Why
The shared core test harness does not need to spawn a login shell for every
test, and approval scenarios exercise tool behavior rather than rollout
persistence.
What changed
ShellSnapshotby default intest_codex(); snapshot-specific testscan continue to opt in explicitly.
durable rollout storage.