Skip to content

Keep active-turn environments stable across settings updates - #33658

Merged
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/c6f4388c843384ef045b7abdbc303dcfca11d230
Jul 16, 2026
Merged

Keep active-turn environments stable across settings updates#33658
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/c6f4388c843384ef045b7abdbc303dcfca11d230

Conversation

@copyberry

@copyberry copyberry Bot commented Jul 16, 2026

Copy link
Copy Markdown

Keep active-turn environments stable across settings updates

Why

With deferred execution enabled, rebuilding a step context from the latest
thread environment snapshot could apply a settings update to a turn that was
already in progress.

What changed

  • Preserve each turn's captured environment selections when creating later
    step contexts.
  • Refresh only the readiness of environments that were already starting, while
    retaining their original selection order.
  • Apply updated environment selections to the next turn.

Testing

Add coverage for changing the selected workspace while a turn is paused,
verifying that the active turn keeps its original working directory and the
next turn uses the new one.

## Why

With deferred execution enabled, rebuilding a step context from the latest
thread environment snapshot could apply a settings update to a turn that was
already in progress.

## What changed

- Preserve each turn's captured environment selections when creating later
  step contexts.
- Refresh only the readiness of environments that were already starting, while
  retaining their original selection order.
- Apply updated environment selections to the next turn.

## Testing

Add coverage for changing the selected workspace while a turn is paused,
verifying that the active turn keeps its original working directory and the
next turn uses the new one.

GitOrigin-RevId: c6f4388c843384ef045b7abdbc303dcfca11d230
@copyberry
copyberry Bot force-pushed the copyberry/codex-internal-to-codex-oss/c6f4388c843384ef045b7abdbc303dcfca11d230 branch from bc7255a to c4ce049 Compare July 16, 2026 18:24
@copyberry
copyberry Bot merged commit c4ce049 into main Jul 16, 2026
14 of 32 checks passed
@copyberry
copyberry Bot deleted the copyberry/codex-internal-to-codex-oss/c6f4388c843384ef045b7abdbc303dcfca11d230 branch July 16, 2026 18:26
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 16, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant