Validate reasoning effort after applying spawn roles - #33656
Merged
copyberry[bot] merged 1 commit intoJul 16, 2026
Merged
Conversation
## Why Agent roles can override the model or reasoning effort after the initial `spawn_agent` configuration is validated, leaving an unsupported combination unchecked. ## What changed - Validate the final reasoning effort against model metadata whenever a role changes the spawned agent's model settings. - Preserve independently configured subagent defaults when a role does not override them. - Apply the same role validation in both multi-agent spawn implementations. ## Testing Added coverage for independent model and reasoning defaults, instruction-only roles, and rejection of a reasoning effort unsupported by a role-selected model. GitOrigin-RevId: 1885314e9380f778603f067fc04a6225ee963428
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/1885314e9380f778603f067fc04a6225ee963428
branch
from
July 16, 2026 18:17
afa1d06 to
8a7c854
Compare
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/1885314e9380f778603f067fc04a6225ee963428
branch
July 16, 2026 18:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validate reasoning effort after applying spawn roles
Why
Agent roles can override the model or reasoning effort after the initial
spawn_agentconfiguration is validated, leaving an unsupported combinationunchecked.
What changed
changes the spawned agent's model settings.
override them.
Testing
Added coverage for independent model and reasoning defaults, instruction-only
roles, and rejection of a reasoning effort unsupported by a role-selected
model.