Strengthen forced rm command detection - #33464
Merged
copyberry[bot] merged 1 commit intoJul 16, 2026
Merged
Conversation
## Why Forced `rm` commands can appear inside complex shell syntax or use option and wrapper variants that the existing dangerous-command heuristic does not recognize. ## What changed - Detect literal forced `rm` invocations in control flow, substitutions, pipelines, traps, nested shells, and `sudo` or `env` wrappers. - Recognize combined, separate, and long-form force options, including when they follow operands. - Require approval for these commands, or reject them with a safer-alternative explanation when approvals are disabled, even when the sandbox is disabled. - Preserve existing rejection reasons for other dangerous commands and explicit policy rules. ## Testing Add unit, policy, and end-to-end coverage for forced `rm` variants, complex shell scripts, approval requests, and rejection messages. GitOrigin-RevId: e1fabc55324e788bae00ab24aae50d089eb7b058
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/e1fabc55324e788bae00ab24aae50d089eb7b058
branch
from
July 16, 2026 01:13
d2c4e9a to
be39aab
Compare
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/e1fabc55324e788bae00ab24aae50d089eb7b058
branch
July 16, 2026 01:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Strengthen forced
rmcommand detectionWhy
Forced
rmcommands can appear inside complex shell syntax or use option and wrapper variants that the existing dangerous-command heuristic does not recognize.What changed
rminvocations in control flow, substitutions, pipelines, traps, nested shells, andsudoorenvwrappers.Testing
Add unit, policy, and end-to-end coverage for forced
rmvariants, complex shell scripts, approval requests, and rejection messages.