Skip to content

[release/0.144] fix(core) expand is_dangerous_command#33455

Merged
dylan-hurd-oai merged 7 commits into
release/0.144from
agent/cherry-pick-pr-1942-release-0.144
Jul 16, 2026
Merged

[release/0.144] fix(core) expand is_dangerous_command#33455
dylan-hurd-oai merged 7 commits into
release/0.144from
agent/cherry-pick-pr-1942-release-0.144

Conversation

@dylan-hurd-oai

Copy link
Copy Markdown
Contributor

Summary

Cherry-picks the seven commits from openai/codex-internal#1942 onto release/0.144.

This backport:

  1. enables dangerous-command detection in danger-full-access mode
  2. expands literal Bash parsing so additional forced rm forms are detected
  3. returns a specific rejection reason to the model when a dangerous command is denied

The commits applied without conflicts or release-only changes. git range-diff confirms every cherry-picked patch matches the source PR exactly.

Validation

  • just test -p codex-shell-command (141 passed)
  • just test -p codex-core exec_policy (107 passed)
  • just test -p codex-core outside the sandbox (2,947 passed; 4 unrelated environment/setup failures)
    • 3 RMCP tests could not locate the test-only test_stdio_server binary
    • 1 user-shell environment test observed the tool runner's mandated CODEX_SANDBOX_NETWORK_DISABLED=1
  • just fix -p codex-core
  • just fix -p codex-shell-command
  • just fmt
  • git diff --check

@dylan-hurd-oai
dylan-hurd-oai marked this pull request as ready for review July 16, 2026 00:57
@dylan-hurd-oai
dylan-hurd-oai merged commit 215fb46 into release/0.144 Jul 16, 2026
64 of 66 checks passed
@dylan-hurd-oai
dylan-hurd-oai deleted the agent/cherry-pick-pr-1942-release-0.144 branch July 16, 2026 01:09
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 16, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants