Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions codex-rs/analytics/src/analytics_client_tests.rs
Original file line number Diff line number Diff line change
Expand Up @@ -377,6 +377,7 @@ fn sample_turn_token_usage_fact(thread_id: &str, turn_id: &str) -> TurnTokenUsag
total_tokens: 321,
input_tokens: 123,
cached_input_tokens: 45,
cache_write_input_tokens: 7,
output_tokens: 140,
reasoning_output_tokens: 13,
},
Expand Down Expand Up @@ -1317,6 +1318,7 @@ fn compaction_event_serializes_expected_shape() {
retained_image_count: None,
compaction_summary_tokens: None,
cached_input_tokens: None,
cache_write_input_tokens: Some(456),
started_at: 100,
completed_at: 106,
duration_ms: Some(6543),
Expand Down Expand Up @@ -1369,6 +1371,7 @@ fn compaction_event_serializes_expected_shape() {
"retained_image_count": null,
"compaction_summary_tokens": null,
"cached_input_tokens": null,
"cache_write_input_tokens": 456,
"started_at": 100,
"completed_at": 106,
"duration_ms": 6543
Expand Down Expand Up @@ -1867,6 +1870,7 @@ async fn thread_originator_overrides_shared_connection_across_thread_events() {
retained_image_count: None,
compaction_summary_tokens: None,
cached_input_tokens: None,
cache_write_input_tokens: None,
started_at: 100,
completed_at: 101,
duration_ms: Some(1200),
Expand Down Expand Up @@ -2045,6 +2049,7 @@ async fn compaction_event_ingests_custom_fact() {
retained_image_count: None,
compaction_summary_tokens: None,
cached_input_tokens: None,
cache_write_input_tokens: None,
started_at: 100,
completed_at: 101,
duration_ms: Some(1200),
Expand Down Expand Up @@ -2186,6 +2191,7 @@ async fn guardian_review_event_ingests_custom_fact_with_optional_target_item() {
completed_at: Some(190),
input_tokens: None,
cached_input_tokens: None,
cache_write_input_tokens: None,
output_tokens: None,
reasoning_output_tokens: None,
total_tokens: None,
Expand Down Expand Up @@ -3011,6 +3017,7 @@ async fn subagent_events_keep_thread_originator_with_explicit_turn_connection()
retained_image_count: None,
compaction_summary_tokens: None,
cached_input_tokens: None,
cache_write_input_tokens: None,
started_at: 100,
completed_at: 101,
duration_ms: Some(1200),
Expand Down Expand Up @@ -3939,6 +3946,7 @@ fn turn_event_serializes_expected_shape() {
image_generation_count: None,
input_tokens: None,
cached_input_tokens: None,
cache_write_input_tokens: None,
output_tokens: None,
reasoning_output_tokens: None,
total_tokens: None,
Expand Down Expand Up @@ -4011,6 +4019,7 @@ fn turn_event_serializes_expected_shape() {
"image_generation_count": null,
"input_tokens": null,
"cached_input_tokens": null,
"cache_write_input_tokens": null,
"output_tokens": null,
"reasoning_output_tokens": null,
"total_tokens": null,
Expand Down Expand Up @@ -4342,6 +4351,10 @@ async fn turn_lifecycle_emits_turn_event() {
assert_eq!(payload["event_params"]["duration_ms"], json!(1234));
assert_eq!(payload["event_params"]["input_tokens"], json!(123));
assert_eq!(payload["event_params"]["cached_input_tokens"], json!(45));
assert_eq!(
payload["event_params"]["cache_write_input_tokens"],
json!(7)
);
assert_eq!(payload["event_params"]["output_tokens"], json!(140));
assert_eq!(
payload["event_params"]["reasoning_output_tokens"],
Expand Down
8 changes: 8 additions & 0 deletions codex-rs/analytics/src/events.rs
Original file line number Diff line number Diff line change
Expand Up @@ -303,6 +303,7 @@ pub struct GuardianReviewEventParams {
pub completed_at: Option<u64>,
pub input_tokens: Option<i64>,
pub cached_input_tokens: Option<i64>,
pub cache_write_input_tokens: Option<i64>,
pub output_tokens: Option<i64>,
pub reasoning_output_tokens: Option<i64>,
pub total_tokens: Option<i64>,
Expand Down Expand Up @@ -385,6 +386,10 @@ impl GuardianReviewTrackContext {
.token_usage
.as_ref()
.map(|usage| usage.cached_input_tokens),
cache_write_input_tokens: result
.token_usage
.as_ref()
.map(|usage| usage.cache_write_input_tokens),
output_tokens: result.token_usage.as_ref().map(|usage| usage.output_tokens),
reasoning_output_tokens: result
.token_usage
Expand Down Expand Up @@ -822,6 +827,7 @@ pub(crate) struct CodexCompactionEventParams {
pub(crate) retained_image_count: Option<usize>,
pub(crate) compaction_summary_tokens: Option<i64>,
pub(crate) cached_input_tokens: Option<i64>,
pub(crate) cache_write_input_tokens: Option<i64>,
pub(crate) started_at: u64,
pub(crate) completed_at: u64,
pub(crate) duration_ms: Option<u64>,
Expand Down Expand Up @@ -901,6 +907,7 @@ pub(crate) struct CodexTurnEventParams {
pub(crate) image_generation_count: Option<usize>,
pub(crate) input_tokens: Option<i64>,
pub(crate) cached_input_tokens: Option<i64>,
pub(crate) cache_write_input_tokens: Option<i64>,
pub(crate) output_tokens: Option<i64>,
pub(crate) reasoning_output_tokens: Option<i64>,
pub(crate) total_tokens: Option<i64>,
Expand Down Expand Up @@ -1170,6 +1177,7 @@ pub(crate) fn codex_compaction_event_params(
retained_image_count: input.retained_image_count,
compaction_summary_tokens: input.compaction_summary_tokens,
cached_input_tokens: input.cached_input_tokens,
cache_write_input_tokens: input.cache_write_input_tokens,
started_at: input.started_at,
completed_at: input.completed_at,
duration_ms: input.duration_ms,
Expand Down
1 change: 1 addition & 0 deletions codex-rs/analytics/src/facts.rs
Original file line number Diff line number Diff line change
Expand Up @@ -420,6 +420,7 @@ pub struct CodexCompactionEvent {
pub retained_image_count: Option<usize>,
pub compaction_summary_tokens: Option<i64>,
pub cached_input_tokens: Option<i64>,
pub cache_write_input_tokens: Option<i64>,
pub started_at: u64,
pub completed_at: u64,
pub duration_ms: Option<u64>,
Expand Down
3 changes: 3 additions & 0 deletions codex-rs/analytics/src/reducer.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2687,6 +2687,9 @@ fn codex_turn_event_params(
cached_input_tokens: token_usage
.as_ref()
.map(|token_usage| token_usage.cached_input_tokens),
cache_write_input_tokens: token_usage
.as_ref()
.map(|token_usage| token_usage.cache_write_input_tokens),
output_tokens: token_usage
.as_ref()
.map(|token_usage| token_usage.output_tokens),
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions codex-rs/app-server-protocol/src/protocol/v2/thread.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1453,6 +1453,9 @@ pub struct TokenUsageBreakdown {
pub input_tokens: i64,
#[ts(type = "number")]
pub cached_input_tokens: i64,
#[serde(default)]
#[ts(type = "number")]
pub cache_write_input_tokens: i64,
#[ts(type = "number")]
pub output_tokens: i64,
#[ts(type = "number")]
Expand All @@ -1465,6 +1468,7 @@ impl From<CoreTokenUsage> for TokenUsageBreakdown {
total_tokens: value.total_tokens,
input_tokens: value.input_tokens,
cached_input_tokens: value.cached_input_tokens,
cache_write_input_tokens: value.cache_write_input_tokens,
output_tokens: value.output_tokens,
reasoning_output_tokens: value.reasoning_output_tokens,
}
Expand Down
2 changes: 2 additions & 0 deletions codex-rs/app-server/src/bespoke_event_handling.rs
Original file line number Diff line number Diff line change
Expand Up @@ -3708,13 +3708,15 @@ mod tests {
total_token_usage: TokenUsage {
input_tokens: 100,
cached_input_tokens: 25,
cache_write_input_tokens: 0,
output_tokens: 50,
reasoning_output_tokens: 9,
total_tokens: 200,
},
last_token_usage: TokenUsage {
input_tokens: 10,
cached_input_tokens: 5,
cache_write_input_tokens: 0,
output_tokens: 7,
reasoning_output_tokens: 1,
total_tokens: 23,
Expand Down
2 changes: 2 additions & 0 deletions codex-rs/app-server/tests/common/rollout.rs
Original file line number Diff line number Diff line change
Expand Up @@ -118,13 +118,15 @@ pub fn create_fake_rollout_with_token_usage(
total_token_usage: TokenUsage {
input_tokens: 120,
cached_input_tokens: 20,
cache_write_input_tokens: 0,
output_tokens: 30,
reasoning_output_tokens: 10,
total_tokens: 150,
},
last_token_usage: TokenUsage {
input_tokens: 70,
cached_input_tokens: 10,
cache_write_input_tokens: 0,
output_tokens: 20,
reasoning_output_tokens: 5,
total_tokens: 90,
Expand Down
2 changes: 2 additions & 0 deletions codex-rs/app-server/tests/suite/v2/thread_resume.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2401,13 +2401,15 @@ async fn thread_resume_token_usage_replay_can_belong_to_interrupted_turn() -> Re
total_token_usage: TokenUsage {
input_tokens: 180,
cached_input_tokens: 40,
cache_write_input_tokens: 0,
output_tokens: 50,
reasoning_output_tokens: 15,
total_tokens: 230,
},
last_token_usage: TokenUsage {
input_tokens: 90,
cached_input_tokens: 30,
cache_write_input_tokens: 0,
output_tokens: 40,
reasoning_output_tokens: 12,
total_tokens: 130,
Expand Down
38 changes: 33 additions & 5 deletions codex-rs/codex-api/src/sse/responses.rs
Original file line number Diff line number Diff line change
Expand Up @@ -130,12 +130,11 @@ struct ResponseCompletedUsage {

impl From<ResponseCompletedUsage> for TokenUsage {
fn from(val: ResponseCompletedUsage) -> Self {
let input_tokens_details = val.input_tokens_details.unwrap_or_default();
TokenUsage {
input_tokens: val.input_tokens,
cached_input_tokens: val
.input_tokens_details
.map(|d| d.cached_tokens)
.unwrap_or(0),
cached_input_tokens: input_tokens_details.cached_tokens,
cache_write_input_tokens: input_tokens_details.cache_write_tokens,
output_tokens: val.output_tokens,
reasoning_output_tokens: val
.output_tokens_details
Expand All @@ -146,9 +145,11 @@ impl From<ResponseCompletedUsage> for TokenUsage {
}
}

#[derive(Debug, Deserialize)]
#[derive(Debug, Default, Deserialize)]
struct ResponseCompletedInputTokensDetails {
cached_tokens: i64,
#[serde(default)]
cache_write_tokens: i64,
}

#[derive(Debug, Deserialize)]
Expand Down Expand Up @@ -805,6 +806,33 @@ mod tests {
}
}

#[test]
fn parses_cache_write_token_usage() {
let usage: ResponseCompletedUsage = serde_json::from_value(json!({
"input_tokens": 100,
"input_tokens_details": {
"cached_tokens": 40,
"cache_write_tokens": 60
},
"output_tokens": 10,
"output_tokens_details": { "reasoning_tokens": 5 },
"total_tokens": 110
}))
.expect("valid response usage");

assert_eq!(
TokenUsage::from(usage),
TokenUsage {
input_tokens: 100,
cached_input_tokens: 40,
cache_write_input_tokens: 60,
output_tokens: 10,
reasoning_output_tokens: 5,
total_tokens: 110,
}
);
}

#[tokio::test]
async fn parses_reasoning_summary_done() {
let events = run_sse(vec![
Expand Down
9 changes: 1 addition & 8 deletions codex-rs/core/src/client.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2002,14 +2002,7 @@ where
}) => {
feedback_tags!(last_model_response_id = &response_id);
if let Some(usage) = &token_usage {
session_telemetry.sse_event_completed(
usage.input_tokens,
usage.output_tokens,
Some(usage.cached_input_tokens),
Some(usage.reasoning_output_tokens),
usage.total_tokens,
ttft_ms,
);
session_telemetry.sse_event_completed(usage, ttft_ms);
}
inference_trace_attempt.record_completed(
&response_id,
Expand Down
3 changes: 3 additions & 0 deletions codex-rs/core/src/compact.rs
Original file line number Diff line number Diff line change
Expand Up @@ -395,6 +395,7 @@ pub(crate) struct CompactionAnalyticsDetails {
pub(crate) retained_image_count: Option<usize>,
pub(crate) compaction_summary_tokens: Option<i64>,
pub(crate) cached_input_tokens: Option<i64>,
pub(crate) cache_write_input_tokens: Option<i64>,
}

impl CompactionAnalyticsAttempt {
Expand Down Expand Up @@ -432,6 +433,7 @@ impl CompactionAnalyticsAttempt {
retained_image_count,
compaction_summary_tokens,
cached_input_tokens,
cache_write_input_tokens,
} = details;
let active_context_tokens_before =
active_context_tokens_before.unwrap_or(self.active_context_tokens_before);
Expand All @@ -455,6 +457,7 @@ impl CompactionAnalyticsAttempt {
retained_image_count,
compaction_summary_tokens,
cached_input_tokens,
cache_write_input_tokens,
started_at: self.started_at,
completed_at: now_unix_seconds(),
duration_ms: Some(
Expand Down
3 changes: 3 additions & 0 deletions codex-rs/core/src/compact_remote_v2.rs
Original file line number Diff line number Diff line change
Expand Up @@ -277,6 +277,7 @@ async fn run_remote_compact_task_inner_impl(
analytics_details.active_context_tokens_before = Some(token_usage.input_tokens);
analytics_details.compaction_summary_tokens = Some(token_usage.output_tokens);
analytics_details.cached_input_tokens = Some(token_usage.cached_input_tokens);
analytics_details.cache_write_input_tokens = Some(token_usage.cache_write_input_tokens);
}
let (compacted_history, retained_images) =
build_v2_compacted_history(&prompt_input, compaction_output);
Expand Down Expand Up @@ -835,6 +836,7 @@ mod tests {
token_usage: Some(TokenUsage {
input_tokens: 123_456,
cached_input_tokens: 7_890,
cache_write_input_tokens: 0,
output_tokens: 42,
reasoning_output_tokens: 5,
total_tokens: 123_498,
Expand All @@ -854,6 +856,7 @@ mod tests {
Some(TokenUsage {
input_tokens: 123_456,
cached_input_tokens: 7_890,
cache_write_input_tokens: 0,
output_tokens: 42,
reasoning_output_tokens: 5,
total_tokens: 123_498,
Expand Down
Loading
Loading