Skip to content

Avoid creating metadata paths in the Windows sandbox - #33430

Merged
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/701bcb229f631b18ab5ced22f3edf6f303d932f3
Jul 15, 2026
Merged

Avoid creating metadata paths in the Windows sandbox#33430
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/701bcb229f631b18ab5ced22f3edf6f303d932f3

Conversation

@copyberry

@copyberry copyberry Bot commented Jul 15, 2026

Copy link
Copy Markdown

Avoid creating metadata paths in the Windows sandbox

Why

Elevated Windows sandbox setup could turn the built-in read-only protections
for workspace metadata into deny-write paths, creating metadata directories
that did not already exist.

What changed

  • Track whether filesystem permission entries come from a built-in profile or
    were explicitly configured.
  • Exclude generated metadata defaults from direct Windows deny-write overrides
    while continuing to enforce explicit read-only carveouts for the same paths.
  • Preserve the distinction while materializing and normalizing permission
    paths, without exposing generated defaults as user configuration.

Testing

Added Windows coverage confirming that elevated sandbox setup leaves missing
workspace metadata absent and still produces overrides for explicit metadata
carveouts.

## Why

Elevated Windows sandbox setup could turn the built-in read-only protections
for workspace metadata into deny-write paths, creating metadata directories
that did not already exist.

## What changed

- Track whether filesystem permission entries come from a built-in profile or
  were explicitly configured.
- Exclude generated metadata defaults from direct Windows deny-write overrides
  while continuing to enforce explicit read-only carveouts for the same paths.
- Preserve the distinction while materializing and normalizing permission
  paths, without exposing generated defaults as user configuration.

## Testing

Added Windows coverage confirming that elevated sandbox setup leaves missing
workspace metadata absent and still produces overrides for explicit metadata
carveouts.

GitOrigin-RevId: 701bcb229f631b18ab5ced22f3edf6f303d932f3
@copyberry
copyberry Bot force-pushed the copyberry/codex-internal-to-codex-oss/701bcb229f631b18ab5ced22f3edf6f303d932f3 branch from 841c350 to cb79b3c Compare July 15, 2026 21:20
@copyberry
copyberry Bot merged commit cb79b3c into main Jul 15, 2026
14 of 32 checks passed
@copyberry
copyberry Bot deleted the copyberry/codex-internal-to-codex-oss/701bcb229f631b18ab5ced22f3edf6f303d932f3 branch July 15, 2026 21:21
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 15, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants