Skip to content

Run detached reviews as review-agent turns - #33156

Merged
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/979664cd80800fb0d51eabdc4e3211da90c12db9
Jul 14, 2026
Merged

Run detached reviews as review-agent turns#33156
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/979664cd80800fb0d51eabdc4e3211da90c12db9

Conversation

@copyberry

@copyberry copyberry Bot commented Jul 14, 2026

Copy link
Copy Markdown

Run detached reviews as review-agent turns

Why

Detached reviews should behave like ordinary forked turns so clients get the normal steering, tool, permission, and item-stream behavior.

What changed

  • Add a bundled $review-agent skill with read-only, defect-first review guidance.
  • Start detached reviews through AgentRunner with a target-specific prompt that explicitly references the bundled skill. Keep inline reviews on the existing review-mode flow.
  • Continue emitting the detached review thread and turn identifiers through the app-server API.

Testing

  • Update the detached review integration test to verify the forked turn prompt, ordinary turn completion, and selection of the bundled skill when a user skill has the same name.

## Why

Detached reviews should behave like ordinary forked turns so clients get the normal steering, tool, permission, and item-stream behavior.

## What changed

- Add a bundled `$review-agent` skill with read-only, defect-first review guidance.
- Start detached reviews through `AgentRunner` with a target-specific prompt that explicitly references the bundled skill. Keep inline reviews on the existing review-mode flow.
- Continue emitting the detached review thread and turn identifiers through the app-server API.

## Testing

- Update the detached review integration test to verify the forked turn prompt, ordinary turn completion, and selection of the bundled skill when a user skill has the same name.

GitOrigin-RevId: 979664cd80800fb0d51eabdc4e3211da90c12db9
@copyberry
copyberry Bot force-pushed the copyberry/codex-internal-to-codex-oss/979664cd80800fb0d51eabdc4e3211da90c12db9 branch from 44e9f84 to 83a4187 Compare July 14, 2026 20:57
@copyberry
copyberry Bot merged commit 83a4187 into main Jul 14, 2026
12 of 30 checks passed
@copyberry
copyberry Bot deleted the copyberry/codex-internal-to-codex-oss/979664cd80800fb0d51eabdc4e3211da90c12db9 branch July 14, 2026 20:59
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 14, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants