Allow injecting the models manager into ThreadManager - #32911
Merged
copyberry[bot] merged 1 commit intoJul 14, 2026
Merged
Conversation
## Why Embedding callers need to control whether model catalogs are persisted to disk. ## What changed - Accept a shared models manager when constructing `ThreadManager` instead of always creating a cached manager internally. - Add provider APIs for creating uncached model managers. OpenAI-compatible providers fetch on each `OnlineIfUncached` refresh without reading or writing `models_cache.json`. - Keep existing app server, MCP server, sample, and test callers on the standard cached manager. ## Testing - Verify an uncached manager fetches on every refresh. - Verify an injected uncached manager controls thread refresh behavior and does not create `models_cache.json`. GitOrigin-RevId: 8bb646054ecec4ccb865b2bf56249384916ea9db
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/8bb646054ecec4ccb865b2bf56249384916ea9db
branch
from
July 14, 2026 01:07
63ed84e to
80c6cd3
Compare
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/8bb646054ecec4ccb865b2bf56249384916ea9db
branch
July 14, 2026 01:08
sdbjbjghtd-hub
temporarily deployed
to
issue-triage
July 14, 2026 01:16 — with 
GitHub Actions
Inactive
sdbjbjghtd-hub
temporarily deployed
to
issue-triage
July 14, 2026 01:16 — with
GitHub Actions
Inactive
sdbjbjghtd-hub
temporarily deployed
to
issue-triage
July 14, 2026 01:16 — with
GitHub Actions
Inactive
jiangshengdev
temporarily deployed
to
issue-triage
July 14, 2026 01:17 — with
GitHub Actions
Inactive
jiangshengdev
temporarily deployed
to
issue-triage
July 14, 2026 01:17 — with
GitHub Actions
Inactive
jiangshengdev
temporarily deployed
to
issue-triage
July 14, 2026 01:17 — with
GitHub Actions
Inactive
jiangshengdev
temporarily deployed
to
issue-triage
July 14, 2026 01:18 — with
GitHub Actions
Inactive
drdave-flexnetos
temporarily deployed
to
issue-triage
July 14, 2026 01:50 — with
GitHub Actions
Inactive
drdave-flexnetos
temporarily deployed
to
issue-triage
July 14, 2026 01:50 — with
GitHub Actions
Inactive
drdave-flexnetos
temporarily deployed
to
issue-triage
July 14, 2026 01:50 — with
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow injecting the models manager into
ThreadManagerWhy
Embedding callers need to control whether model catalogs are persisted to disk.
What changed
ThreadManagerinstead of always creating a cached manager internally.OnlineIfUncachedrefresh without reading or writingmodels_cache.json.Testing
models_cache.json.