Skip to content

Refactor OAuth store lock contention tests - #32801

Merged
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/74b8b5370456e90ecd39fc2af2f0853594ca4f60
Jul 13, 2026
Merged

Refactor OAuth store lock contention tests#32801
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/74b8b5370456e90ecd39fc2af2f0853594ca4f60

Conversation

@copyberry

@copyberry copyberry Bot commented Jul 13, 2026 •
edited
Loading

Copy link
Copy Markdown

Refactor OAuth store lock contention tests

What changed

  • Extend the lock-contention test helper with a callback that runs while the
    aggregate store lock is held.
  • Use a scoped worker thread and return its result directly after releasing the
    lock.
  • Reuse the helper for concurrent update tests covering both file and secrets
    credential stores.

@jif-oai copyberry
Refactor OAuth store lock contention tests (#32801)
c7a4a7e 
## What changed

- Extend the lock-contention test helper with a callback that runs while the
  aggregate store lock is held.
- Use a scoped worker thread and return its result directly after releasing the
  lock.
- Reuse the helper for concurrent update tests covering both file and secrets
  credential stores.

GitOrigin-RevId: 74b8b5370456e90ecd39fc2af2f0853594ca4f60
@copyberry
copyberry Bot force-pushed the copyberry/codex-internal-to-codex-oss/74b8b5370456e90ecd39fc2af2f0853594ca4f60 branch from 2e1f5fe to c7a4a7e Compare July 13, 2026 13:57
@copyberry
copyberry Bot merged commit c7a4a7e into main Jul 13, 2026
14 of 32 checks passed
@copyberry
copyberry Bot deleted the copyberry/codex-internal-to-codex-oss/74b8b5370456e90ecd39fc2af2f0853594ca4f60 branch July 13, 2026 13:58
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 13, 2026
@qbawu
qbawu temporarily deployed to issue-triage July 13, 2026 14:06 — with GitHub Actions Inactive
@qbawu
qbawu temporarily deployed to issue-triage July 13, 2026 14:06 — with GitHub Actions Inactive
@qbawu
qbawu temporarily deployed to issue-triage July 13, 2026 14:06 — with GitHub Actions Inactive
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.