Skip to content

Expand tabs when rendering TUI diffs - #32461

Merged
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/2159e84991b844ea8c4c57dfad52bc3fe7a9059f
Jul 11, 2026
Merged

Expand tabs when rendering TUI diffs#32461
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/2159e84991b844ea8c4c57dfad52bc3fe7a9059f

Conversation

@copyberry

@copyberry copyberry Bot commented Jul 11, 2026

Copy link
Copy Markdown

Expand tabs when rendering TUI diffs

What changed

  • Replace tab characters in rendered diff spans with four spaces while keeping
    their wrapping width and style intact.
  • Ensure diff buffers never contain literal tab characters.

Testing

  • Cover tab expansion and wrapping in wrap_styled_spans.
  • Update diff gallery snapshots at multiple terminal sizes.

## What changed

- Replace tab characters in rendered diff spans with four spaces while keeping
  their wrapping width and style intact.
- Ensure diff buffers never contain literal tab characters.

## Testing

- Cover tab expansion and wrapping in `wrap_styled_spans`.
- Update diff gallery snapshots at multiple terminal sizes.

GitOrigin-RevId: 2159e84991b844ea8c4c57dfad52bc3fe7a9059f
@copyberry
copyberry Bot force-pushed the copyberry/codex-internal-to-codex-oss/2159e84991b844ea8c4c57dfad52bc3fe7a9059f branch from 4537020 to 385c0a9 Compare July 11, 2026 17:48
@copyberry
copyberry Bot merged commit 385c0a9 into main Jul 11, 2026
14 of 32 checks passed
@copyberry
copyberry Bot deleted the copyberry/codex-internal-to-codex-oss/2159e84991b844ea8c4c57dfad52bc3fe7a9059f branch July 11, 2026 17:49
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 11, 2026
@oiwn
oiwn temporarily deployed to issue-triage July 11, 2026 18:33 — with GitHub Actions Inactive
@oiwn
oiwn temporarily deployed to issue-triage July 11, 2026 18:33 — with GitHub Actions Inactive
@oiwn
oiwn temporarily deployed to issue-triage July 11, 2026 18:33 — with GitHub Actions Inactive
@Niass
Niass temporarily deployed to issue-triage July 11, 2026 19:10 — with GitHub Actions Inactive
@Niass
Niass temporarily deployed to issue-triage July 11, 2026 19:10 — with GitHub Actions Inactive
@Niass
Niass temporarily deployed to issue-triage July 11, 2026 19:10 — with GitHub Actions Inactive
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.