Skip to content

Clarify waiting behavior in safety buffering prompts #32286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copyberry merged 1 commit into from
Jul 10, 2026
+10 −5
Merged

Clarify waiting behavior in safety buffering prompts #32286

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion codex-rs/tui/src/chatwidget/safety_buffering.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ const SAFETY_BUFFERING_LEARN_MORE_URL: &str = "https://help.openai.com/en/articl
const SAFETY_BUFFERING_HEADER: &str =
"Our systems are thinking a bit more about this request before responding.";
const SAFETY_BUFFERING_MESSAGE_WITH_RETRY: &str = "Hang tight or retry with a faster model for a quicker response, though it may be less capable of handling complex requests.";
const SAFETY_BUFFERING_FOOTER: &str = "No action is required. Codex will keep waiting, and this menu will close when the response is ready.";

#[derive(Debug)]
struct ActiveSafetyBuffering {
Expand Down Expand Up @@ -184,7 +185,7 @@ impl ChatWidget {
}
items.extend([
SelectionItem {
name: "Keep waiting".to_string(),
name: "Dismiss and keep waiting".to_string(),
dismiss_on_select: true,
..Default::default()
},
Expand All @@ -201,6 +202,8 @@ impl ChatWidget {
self.bottom_pane.show_selection_view(SelectionViewParams {
view_id: Some(SAFETY_BUFFERING_PROMPT_VIEW_ID),
header: Box::new(header),
footer_note: Some(Line::from(SAFETY_BUFFERING_FOOTER).dim()),
footer_hint: Some(Line::default()),
items,
..Default::default()
});
Expand Down
5 changes: 3 additions & 2 deletions ...src/chatwidget/snapshots/codex_tui__chatwidget__tests__safety_buffering_retry_prompt.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@ expression: popup
may be less capable of handling complex requests.

› 1. Retry with a faster model
2. Keep waiting
2. Dismiss and keep waiting
3. Learn more

Press enter to confirm or esc to go back
No action is required. Codex will keep waiting, and this menu will close when
the response is ready.
5 changes: 3 additions & 2 deletions ...widget/snapshots/codex_tui__chatwidget__tests__safety_buffering_status_without_retry.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@ expression: popup
---
Our systems are thinking a bit more about this request before responding.

› 1. Keep waiting
› 1. Dismiss and keep waiting
2. Learn more

Press enter to confirm or esc to go back
No action is required. Codex will keep waiting, and this menu will close when
the response is ready.
Loading