Include terminal errors in turn completion events - #32280
Merged
copyberry[bot] merged 1 commit intoJul 10, 2026
Merged
Conversation
## What changed - Add an optional `error` payload to `TurnCompleteEvent` and omit it when a turn completes without an error. - Preserve the full terminal `ErrorEvent` through the turn lifecycle so the completion event includes the same error details emitted separately by `EventMsg::Error`. ## Testing - Extend the stream-error integration test to verify that `TurnCompleteEvent` contains the emitted error and that the next turn can still proceed. GitOrigin-RevId: 8d32942a44132763076130102d8b89ab356d59d0
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/8d32942a44132763076130102d8b89ab356d59d0
branch
from
July 10, 2026 22:05
f17cb12 to
c4318c3
Compare
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/8d32942a44132763076130102d8b89ab356d59d0
branch
July 10, 2026 22:06
budhasantosh010
temporarily deployed
to
issue-triage
July 10, 2026 22:14 — with
GitHub Actions
Inactive
budhasantosh010
temporarily deployed
to
issue-triage
July 10, 2026 22:14 — with
GitHub Actions
Inactive
budhasantosh010
temporarily deployed
to
issue-triage
July 10, 2026 22:14 — with
GitHub Actions
Inactive
budhasantosh010
temporarily deployed
to
issue-triage
July 10, 2026 22:15 — with
GitHub Actions
Inactive
mariusvniekerk
temporarily deployed
to
issue-triage
July 10, 2026 22:25 — with
GitHub Actions
Inactive
mariusvniekerk
temporarily deployed
to
issue-triage
July 10, 2026 22:25 — with
GitHub Actions
Inactive
mariusvniekerk
temporarily deployed
to
issue-triage
July 10, 2026 22:25 — with
GitHub Actions
Inactive
Statusnone420
temporarily deployed
to
issue-triage
July 10, 2026 22:25 — with
GitHub Actions
Inactive
Statusnone420
temporarily deployed
to
issue-triage
July 10, 2026 22:25 — with
GitHub Actions
Inactive
Statusnone420
temporarily deployed
to
issue-triage
July 10, 2026 22:25 — with
GitHub Actions
Inactive
mariusvniekerk
temporarily deployed
to
issue-triage
July 10, 2026 22:26 — with
GitHub Actions
Inactive
johnsilvavlogs
temporarily deployed
to
issue-triage
July 10, 2026 22:45 — with
GitHub Actions
Inactive
johnsilvavlogs
temporarily deployed
to
issue-triage
July 10, 2026 22:45 — with
GitHub Actions
Inactive
johnsilvavlogs
temporarily deployed
to
issue-triage
July 10, 2026 22:45 — with
GitHub Actions
Inactive
johnsilvavlogs
temporarily deployed
to
issue-triage
July 10, 2026 22:46 — with
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Include terminal errors in turn completion events
What changed
errorpayload toTurnCompleteEventand omit it when a turn completes without an error.ErrorEventthrough the turn lifecycle so the completion event includes the same error details emitted separately byEventMsg::Error.Testing
TurnCompleteEventcontains the emitted error and that the next turn can still proceed.