Preserve local path conventions in automatic approvals - #32261
Merged
copyberry[bot] merged 1 commit intoJul 10, 2026
Merged
Conversation
## Why Drive-shaped POSIX paths such as `/C:/workspace` can be mistaken for Windows paths when an automatic approval request converts them from `PathUri`. ## What changed - Keep approval paths as `PathUri` values together with their environment ID until the automatic review request is built. - Recover host-native paths for local working directories when strict conversion cannot determine the path convention. - Continue rejecting incompatible paths from remote environments. ## Testing Add coverage for drive-shaped local POSIX paths, foreign remote paths, and preserving apply-patch path URIs while building approval actions. GitOrigin-RevId: 3fd31cfb4e8b46f9968ff66d5e986ca777430185
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/3fd31cfb4e8b46f9968ff66d5e986ca777430185
branch
from
July 10, 2026 20:19
33cf8e5 to
b66c25c
Compare
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/3fd31cfb4e8b46f9968ff66d5e986ca777430185
branch
July 10, 2026 20:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preserve local path conventions in automatic approvals
Why
Drive-shaped POSIX paths such as
/C:/workspacecan be mistaken for Windowspaths when an automatic approval request converts them from
PathUri.What changed
PathUrivalues together with their environment IDuntil the automatic review request is built.
conversion cannot determine the path convention.
Testing
Add coverage for drive-shaped local POSIX paths, foreign remote paths, and
preserving apply-patch path URIs while building approval actions.