Let permission hooks resolve strict auto-review requests - #32232
Merged
copyberry[bot] merged 1 commit intoJul 10, 2026
Merged
Conversation
## What changed - Run permission-request hooks before routing approvals to the automated reviewer or user, including when `strict_auto_review` is enabled. - Centralize approval resolution so hook, automated-reviewer, and user decisions share rejection handling and report the correct telemetry source. ## Testing - Add an integration test showing that an allow hook can approve a shell command during strict auto-review without invoking the automated reviewer. GitOrigin-RevId: 18e9d76baee6cbae9d35ae517250f2f82270a9d2
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/18e9d76baee6cbae9d35ae517250f2f82270a9d2
branch
from
July 10, 2026 18:13
d1f853c to
2da1b12
Compare
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/18e9d76baee6cbae9d35ae517250f2f82270a9d2
branch
July 10, 2026 18:14
ProGraMajster
temporarily deployed
to
issue-triage
July 10, 2026 18:27 — with 
GitHub Actions
Inactive
ProGraMajster
temporarily deployed
to
issue-triage
July 10, 2026 18:27 — with
GitHub Actions
Inactive
ProGraMajster
temporarily deployed
to
issue-triage
July 10, 2026 18:27 — with
GitHub Actions
Inactive
ProGraMajster
temporarily deployed
to
issue-triage
July 10, 2026 18:28 — with
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let permission hooks resolve strict auto-review requests
What changed
strict_auto_reviewis enabled.Testing