Support pending remote environment registration - #32231
Merged
copyberry[bot] merged 1 commit intoJul 10, 2026
Merged
Conversation
## Why Remote environment provisioning can finish after a thread starts, before an exec-server WebSocket URL is available. ## What changed - Add `EnvironmentManager::register_pending_environment` and a one-shot `PendingEnvironmentRegistration` handle that resolves to either a validated WebSocket URL or a terminal provisioning error. - Let lazy remote exec-server clients wait for that result, while preserving reconnection behavior after a successful registration. - Keep replacement registrations isolated so completing an older handle does not resolve the current environment with the same ID. ## Testing Add coverage for successful connection and reconnection, provisioning and dropped-registration failures, invalid URLs, replacement isolation, and the deferred-executor startup flow. GitOrigin-RevId: 5c05be2b72291b77a1f71176d7075b1ad63332a5
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/5c05be2b72291b77a1f71176d7075b1ad63332a5
branch
from
July 10, 2026 18:09
7026aab to
4472698
Compare
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/5c05be2b72291b77a1f71176d7075b1ad63332a5
branch
July 10, 2026 18:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support pending remote environment registration
Why
Remote environment provisioning can finish after a thread starts, before an
exec-server WebSocket URL is available.
What changed
EnvironmentManager::register_pending_environmentand a one-shotPendingEnvironmentRegistrationhandle that resolves to either a validatedWebSocket URL or a terminal provisioning error.
reconnection behavior after a successful registration.
not resolve the current environment with the same ID.
Testing
Add coverage for successful connection and reconnection, provisioning and
dropped-registration failures, invalid URLs, replacement isolation, and the
deferred-executor startup flow.