exec-server: preserve empty workspace roots - #31919
Closed
pakrym-oai wants to merge 11 commits into
Closed
Conversation
pakrym-oai
force-pushed
the
pakrym/full-ci-explicit-empty-workspace-roots
branch
from
July 9, 2026 22:04
344ff06 to
013e186
Compare
pakrym-oai
changed the base branch from
main
to
pakrym/full-ci-fs-workspace-roots
July 9, 2026 22:04
pakrym-oai
marked this pull request as ready for review
July 9, 2026 22:06
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 013e18645e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
pakrym-oai
force-pushed
the
pakrym/full-ci-explicit-empty-workspace-roots
branch
2 times, most recently
from
July 9, 2026 23:37
a412f49 to
38c2321
Compare
pakrym-oai
changed the base branch from
main
to
pakrym/full-ci-linux-sandbox-helper-visibility
July 9, 2026 23:37
pakrym-oai
force-pushed
the
pakrym/full-ci-linux-sandbox-helper-visibility
branch
from
July 10, 2026 00:06
0322c9c to
4b4cac2
Compare
pakrym-oai
force-pushed
the
pakrym/full-ci-explicit-empty-workspace-roots
branch
from
July 10, 2026 00:19
38c2321 to
0a886b7
Compare
pakrym-oai
force-pushed
the
pakrym/full-ci-linux-sandbox-helper-visibility
branch
from
July 10, 2026 00:23
4b4cac2 to
aef7aac
Compare
pakrym-oai
force-pushed
the
pakrym/full-ci-explicit-empty-workspace-roots
branch
4 times, most recently
from
July 10, 2026 01:22
5e14525 to
de6e0a2
Compare
Base automatically changed from
pakrym/full-ci-linux-sandbox-helper-visibility
to
main
July 10, 2026 01:28
pakrym-oai
force-pushed
the
pakrym/full-ci-explicit-empty-workspace-roots
branch
2 times, most recently
from
July 10, 2026 02:01
1233dec to
936ab8b
Compare
pakrym-oai
force-pushed
the
pakrym/full-ci-explicit-empty-workspace-roots
branch
from
July 10, 2026 02:08
936ab8b to
dd51887
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #31892.
Why
Exec-server sandbox contexts carry the concrete roots that define symbolic
:workspace_rootsauthority. Both process and filesystem sandboxing treated an empty root list as if it were missing and rebound it to the sandbox cwd. A caller that intentionally selected no workspace roots could therefore still access cwd files.What changed
from_permission_profile_with_cwdconvenience behavior by carrying cwd as an explicit workspace root.fs/readFileand a sandboxed process cannot read a cwd file after workspace roots are explicitly cleared.Testing
just test -p codex-exec-server --test file_system_unix remote_read_file_preserves_empty_workspace_rootsjust test -p codex-exec-server --test exec_process remote_process_preserves_empty_workspace_roots