core: stop emitting legacy command events directly - #31629
Merged
owenlin0 merged 2 commits intoJul 8, 2026
Merged
Conversation
owenlin0
force-pushed
the
owen/ca-675-emit-unified-exec-interactions-as-canonical-commandexecution
branch
from
July 8, 2026 19:39
9d2f94b to
ea68460
Compare
owenlin0
marked this pull request as ready for review
July 8, 2026 19:47
pakrym-oai
reviewed
Jul 8, 2026
| process_id: Option<&str>, | ||
| ) { | ||
| let (session, turn, rx_event) = | ||
| make_session_and_context_with_dynamic_tools_and_rx(Vec::new()).await; |
Contributor
There was a problem hiding this comment.
is this a good test? can we do an integration one instead (if we need one at all)?
Contributor
Author
There was a problem hiding this comment.
removed the test, we've got existing tests that cover this
pakrym-oai
approved these changes
Jul 8, 2026
owenlin0
enabled auto-merge (squash)
July 8, 2026 20:42
owenlin0
deleted the
owen/ca-675-emit-unified-exec-interactions-as-canonical-commandexecution
branch
July 8, 2026 20:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the last path in core that emits
ExecCommandBegin/ExecCommandEnddirectly.Every command execution now starts and completes through canonical
ItemStarted/ItemCompleted(TurnItem::CommandExecution). The existingHasLegacyEventcompatibility layer still fans out Begin/End afterward, so raw core event consumers and legacy rollout replay keep seeing the same events.UnifiedExecInteractionis dormant today. Live unified exec usesUnifiedExecStartupfor command lifecycle andTerminalInteractionforwrite_stdinand polling, so this is code cleanup rather than a current product behavior change. The main win is the code-level invariant where all core flows emitTurnIteminstead of legacy events.What changed
UnifiedExecInteractionbranches that emitted legacy command events directly.CommandExecutionlifecycle and compatibility fanout.