Use the image generation extension by default - #31596
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6547da9b41
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
won-openai
force-pushed
the
won-imagegenext-default
branch
from
July 8, 2026 17:34
9f34d5a to
5bf5947
Compare
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5bf5947975
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
won-openai
force-pushed
the
won-imagegenext-default
branch
from
July 8, 2026 17:43
5bf5947 to
dbd765f
Compare
pakrym-oai
reviewed
Jul 8, 2026
pakrym-oai
reviewed
Jul 8, 2026
pakrym-oai
reviewed
Jul 8, 2026
pakrym-oai
approved these changes
Jul 8, 2026
## Why After #31596 routes all new image generation through the extension, the built-in hosted pipeline is unreachable and can be removed independently. ## What changed - Remove the hosted image generation tool spec and its code-mode/tool-search handling. - Remove live hosted image-generation stream persistence and the generated-image instruction injection it required. - Delete tests that only covered the removed live pipeline. - Keep protocol/history support for existing `ImageGenerationCall` rollout items, including replay, rollback, and renderable history behavior. ## Validation - `just test -p codex-core stream_events_utils` - `just test -p codex-core generated_image` - `just test -p codex-core image_generation_publication_preserves_extension_saved_path` - `just test -p codex-image-generation-extension` - `just test -p codex-tools` - Scoped Clippy fixes for `codex-core` and `codex-tools`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Image generation should have one implementation path. This cutover makes the image generation extension the default everywhere while preserving the existing stable feature toggle and compatibility alias.
What changed
Feature::ImageGenerationexclusively gate extension-backed image generation and keepimagegenextas a legacy alias.requires_openai_authproviders.Validation
just test -p codex-featuresjust test -p codex-core image_generationjust test -p codex-mcp-server image_generation_extension_is_enabled_by_defaultcargo check -p codex-core-api -p codex-thread-manager-sample