Stabilize shared rollout budget test - #31587
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
subagent_usage_draws_from_the_shared_budgetintermittently fails even when the shared-budget behavior is correct.ResponseMockrecords a request before the custom Wiremock predicate is checked, so the follow-up mock can also contain unrelated requests. In a recent Windows ARM64 run,single_request()saw all seven requests from the scenario.What changed
Select the request containing the follow-up user prompt before making assertions. The test still requires exactly one matching follow-up request and still checks that the root sees 50 tokens remaining after the child uses its share.
This is test-only. Shared-budget behavior and the common response-mock helper are unchanged.