Skip to content

test(skills): cover plugin namespace loading - #31369

Merged
anp-oai merged 3 commits into
mainfrom
codex/skill-namespace-loader-tests
Jul 7, 2026
Merged

test(skills): cover plugin namespace loading#31369
anp-oai merged 3 commits into
mainfrom
codex/skill-namespace-loader-tests

Conversation

@anp-oai

@anp-oai anp-oai commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Why

Before changing plugin namespace loading performance, lock down the existing behavior so the same cases can be validated before and after the optimization.

What

  • cover mixed plain and nested plugin skills under one scan root
  • cover inherited, nested, and invalid-manifest namespace precedence
  • cover symlinked plugin skill directories, symlinked plain directories, and scan-root ancestor symlinks

Validation

  • just test -p codex-core-skills namespace on unmodified main: 12 passed

@anp-oai
anp-oai marked this pull request as ready for review July 7, 2026 06:15
@anp-oai
anp-oai force-pushed the codex/skill-namespace-loader-tests branch from 21a3fea to 4170e22 Compare July 7, 2026 15:54
@anp-oai

anp-oai commented Jul 7, 2026

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown
Contributor

Codex Review: Didn't find any major issues. Already looking forward to the next diff.

Reviewed commit: 4170e22e94

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@anp-oai
anp-oai merged commit 42156ba into main Jul 7, 2026
35 checks passed
@anp-oai
anp-oai deleted the codex/skill-namespace-loader-tests branch July 7, 2026 16:28
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 7, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants