ci: run V8 source builds on Windows 2025 - #31356
Merged
Merged
Conversation
This was referenced Jul 7, 2026
anp-oai
force-pushed
the
codex/dev-drive-windows-2025
branch
from
July 7, 2026 04:42
2a2c345 to
251e09b
Compare
anp-oai
marked this pull request as ready for review
July 7, 2026 06:09
anp-oai
force-pushed
the
codex/dev-drive-windows-2025
branch
from
July 7, 2026 06:18
251e09b to
088856e
Compare
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 251e09b310
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
anp-oai
force-pushed
the
codex/dev-drive-setup-ci
branch
from
July 7, 2026 18:42
c769674 to
707ce5c
Compare
anp-oai
force-pushed
the
codex/dev-drive-windows-2025
branch
from
July 7, 2026 18:43
088856e to
1bb73d7
Compare
anp-oai
added a commit
that referenced
this pull request
Jul 7, 2026
anp-oai
force-pushed
the
codex/dev-drive-setup-ci
branch
from
July 7, 2026 23:54
707ce5c to
329f08d
Compare
anp-oai
added a commit
that referenced
this pull request
Jul 8, 2026
## Why Prepare CI jobs for a later build-output relocation without changing where they write today. ## What - Export `CARGO_TARGET_DIR` from `setup-ci` at the existing `codex-rs/target` path. - Route nextest, release, artifact, and signing paths through `CARGO_TARGET_DIR`. - Require V8 staging callers to pass an explicit target directory while preserving the existing upstream path. ## Manual validation - Ran `just test-github-scripts`. - Parsed GitHub Actions YAML with `yq`. ## Stack - [#31332](#31332) — parameterize Cargo target paths - [#31356](#31356) — Windows 2025 runner bump - [#31357](#31357) — Dev Drive I/O routing
anp-oai
force-pushed
the
codex/dev-drive-windows-2025
branch
from
July 8, 2026 00:03
5daeb21 to
97b4767
Compare
cconger
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The V8 Windows source jobs need a runner image that can support the later Dev Drive setup.
What
Move the two V8 Windows source-build matrix entries from
windows-2022towindows-2025.Namespace the canary source-build cache by runner image so it cannot restore Windows 2022 native outputs.
Manual validation
just fmt.just test-github-scripts(33 tests).yq.git diff --check.Stack