chore: extract remote compaction request attempts - #31316
Merged
Conversation
celia-oai
force-pushed
the
codex/refactor-remote-compaction-attempts
branch
from
July 6, 2026 23:37
4809aa8 to
594fed1
Compare
celia-oai
force-pushed
the
codex/refactor-remote-compaction-attempts
branch
from
July 7, 2026 00:24
594fed1 to
cf62e27
Compare
celia-oai
force-pushed
the
codex/refactor-remote-compaction-attempts
branch
from
July 7, 2026 06:05
ec16a25 to
1f3200a
Compare
celia-oai
marked this pull request as ready for review
July 7, 2026 06:17
Contributor
Author
|
@codex review |
Contributor
|
Codex Review: Didn't find any major issues. Swish! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
sayan-oai
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
This PR is a behavior-preserving refactor only. It does not add a fallback, change which model is used for compaction, or otherwise change compaction behavior. The behavioral change is implemented in the stacked follow-up, #30319.
Pre-sampling compaction deliberately uses the previous turn's context when the compaction compatibility hash changes or when switching to a model with a smaller context window. That preserves the model settings that produced the history being compacted, but the previous context is not always usable. For example, a resumed thread can still reference a model slug that has since been retired, causing compaction to fail before the currently selected model can sample.
#30319 addresses that failure mode by retrying compaction with the current turn's selected model when the backend rejects the previous-model attempt. This PR performs only that preparatory refactor.
What changed
/responses/compactrequest attempt intocompact_remote_request.rs.compact_remote_v2_attempt.rs.Testing
just test -p codex-core -E 'test(remote_compact)'(22 tests)