[codex] Support sequential cutoff reasoning summaries - #31306
Merged
Conversation
ashwinnathan-openai
marked this pull request as ready for review
July 6, 2026 23:30
ashwinnathan-openai
force-pushed
the
codex/sequential-cutoff
branch
from
July 7, 2026 00:19
f7af93f to
e56c3a2
Compare
pakrym-oai
reviewed
Jul 7, 2026
| Arc::clone(&self.turn_state) | ||
| } | ||
|
|
||
| pub(crate) fn uses_sequential_cutoff_reasoning_summaries(&self) -> bool { |
Contributor
There was a problem hiding this comment.
let's not use the client as setting carrier.
pakrym-oai
reviewed
Jul 7, 2026
| }; | ||
| if warmup { | ||
| ws_payload.generate = Some(false); | ||
| ws_payload.stream_options = None; |
Contributor
Author
There was a problem hiding this comment.
unnecessary, dropping
pakrym-oai
reviewed
Jul 7, 2026
| } else { | ||
| (prompt.base_instructions.text.clone(), Some(tools)) | ||
| }; | ||
| let stream_options = |
Contributor
There was a problem hiding this comment.
should probably be conditioned on openai model provider for now?
pakrym-oai
approved these changes
Jul 7, 2026
…uential-cutoff
Contributor
Author
|
@codex review |
Contributor
|
Codex Review: Didn't find any major issues. Keep them coming! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When enabled for the OpenAI provider, Codex sends
stream_options.reasoning_summary_delivery = "sequential_cutoff"on HTTP andWebSocket requests, including prewarm, and renders completed summary sections
from
reasoning_summary_text.done. Flag-off and non-OpenAI behavior isunchanged.
Expected rollout
Depends on openai/openai#1096660.