chore(approvals) consolidate guardian calls for shell tools - #31267
Merged
Conversation
dylan-hurd-oai
marked this pull request as ready for review
July 6, 2026 17:39
pakrym-oai
reviewed
Jul 6, 2026
| req: &UnifiedExecRequest, | ||
| ctx: &ApprovalCtx<'_>, | ||
| ) -> std::io::Result<ApprovalAction> { | ||
| Ok(ApprovalAction::ExecCommand { |
Contributor
There was a problem hiding this comment.
IMO should be the same action as shell but it's outside of this PR scope.
pakrym-oai
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
As part of our effort to start simplifying approvals code, this PR extracts Guardian approvals logic from shell tool calls, and replaces it with the ApprovalAction abstraction instead. This way, tools don't need to know about Guardian at all.
Testing