[codex] Read retry model from buffering events - #31262
Merged
Merged
Conversation
fc-oai
marked this pull request as ready for review
July 6, 2026 16:48
Contributor
Author
|
@codex review |
Contributor
|
Codex Review: Didn't find any major issues. 🎉 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
rhan-oai
approved these changes
Jul 6, 2026
fc-oai
enabled auto-merge (squash)
July 6, 2026 16:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
retry_modelfrom streamedsafety_bufferingpayloadsRoot cause
Follow-up to #31064. The Responses API emits the retry target as
retry_model, but the client was looking forfaster_model, so the payload value was ignored in favor of the compatibility fallback.Behavior
A non-null
retry_modelfrom the buffering payload takes precedence. An explicit null leaves the retry target unset, while an omitted field continues to fall back to the existing response header.Validation
just test -p codex-api(135 tests)just test -p codex-core safety_buffering(2 tests)just fix -p codex-apijust fmtgit diff --check