Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The standalone installers currently perform separate unauthenticated GitHub REST API lookups while resolving the latest version, locating the platform package, locating its checksum manifest, and retrieving asset digests. A single install can therefore make up to four release-metadata requests.
When GitHub's shared unauthenticated rate limit is exhausted, valid releases fail to install. The shell installer also suppresses the metadata request failure while probing assets, so a
403is misreported as though the release assets do not exist. This makes the failure both more likely and harder to diagnose.Fixes #28538.
What changed
install.shandinstall.ps1.curlregression suite covering exact releases,latest, and a simulated metadata403, and run it inrepo-checks.For
latest, the metadata returned by/releases/latestnow supplies both the resolved version and the asset list. For an explicitly selected version, the installer makes one request to that release's tag endpoint.Verification
python3 -m unittest discover -s scripts/install -p 'test_*.py' -vsh -n scripts/install/install.shscripts/install/install.ps1with the PowerShell language parser.Scope
This change reduces GitHub API usage and preserves the underlying error, but it does not move release artifacts away from GitHub's CDN.