[codex] expose remote plugin versions - #30981
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7600575970
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| let plugin_summary = RemotePluginSummary { | ||
| id: plugin_id.as_key(), | ||
| remote_plugin_id: plugin.id.clone(), | ||
| version: None, |
There was a problem hiding this comment.
When plugin/installed builds remote installed marketplaces, fetch_remote_installed_plugins has already decoded each installed item's release.version, but this new PluginSummary.version field is hard-coded to None. In the remote-installed-only path, clients receive version: null for installed remote plugins even though the backend returned a version, so they cannot rely on the newly exposed app-server API field for installed plugins; carry the release version through RemoteInstalledPlugin and use it here.
AGENTS.md reference: AGENTS.md:L298-L300
Useful? React with 👍 / 👎.
7600575 to
5bd29ae
Compare
Summary
PluginSummary.versionfor versions advertised by remote plugin marketplacesplugin/installedresponseslocalVersionas the version of the locally materialized packageTesting
just test -p codex-app-server-protocolplugin/installedremote-version regression testjust test -p codex-app-server plugin_shareplugin/listsmoke test against remote marketplace data