refactor(protocol): isolate legacy item fanout - #30956
Merged
Merged
Conversation
This was referenced Jul 2, 2026
owenlin0
marked this pull request as ready for review
July 6, 2026 18:44
pakrym-oai
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack
TurnItemlifecycleDescription
Move legacy
EventMsgprojection code out of the canonical item and protocol schema modules intoprotocol/src/legacy_events.rs.This is a behavior-neutral extraction. It keeps the existing
HasLegacyEventAPI and the existing legacy projections unchanged, while giving compatibility fanout a single home.Why
Canonical
TurnItemtypes and wire event schemas should not own the implementation details for legacy compatibility projections. Isolating that code makes the boundary explicit and keeps follow-up canonical lifecycle work easier to review.