fix(release): add missing Intel V8 signing entitlement - #30953
Merged
Conversation
|
Who can merge it? We need it |
cconger
approved these changes
Jul 6, 2026
shijie-oai
approved these changes
Jul 6, 2026
anp-oai
reviewed
Jul 7, 2026
anp-oai
left a comment
Contributor
There was a problem hiding this comment.
At a high level I think I'd prefer just having an entitlements file checked in for each binary instead of dynamically selecting them in a script. How hard would that be?
malsamiri-oai
force-pushed
the
codex/se-8006-intel-v8-entitlement
branch
from
July 7, 2026 16:16
4e7df07 to
fba0d47
Compare
malsamiri-oai
enabled auto-merge (squash)
July 7, 2026 16:23
shijie-oai
approved these changes
Jul 7, 2026
Contributor
Author
|
@anp-oai Updated this to use checked-in entitlement files per binary and removed the selector script. |
anp-oai
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Intel macOS release binaries crash on the first Code Mode tool call while V8 creates its code range. The x86_64 V8 allocator later makes a non-
MAP_JITreservation executable, which Hardened Runtime rejects when the signature contains onlycom.apple.security.cs.allow-jit.Tracks SE-8006.
Fixes #28390.
What
allow-jitandallow-unsigned-executable-memorytocodex,codex-app-server, andcodex-code-mode-hostcodex-responses-api-proxyon its existingallow-jit-only profileVerification
just test-github-scripts(33 tests)UV_CACHE_DIR=/private/tmp/codex-uv-cache just fmt-checkplutil -linton all four entitlement profilesrust-release.ymlas YAMLgit diff --checkcodesignverification passed; the Codex profile contained both keys and the proxy profile retained onlyallow-jitRelease validation
Run a native Intel smoke of the final Developer ID-signed x86_64 Codex binary through V8 isolate creation before shipping. PR #30849 is diagnostic scaffolding, but its non-sandbox release job currently fails in the harness before V8 starts, so it is not counted as coverage here.