Conversation
dylan-hurd-oai
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The
cargo-denyjob onmainbegan failing after RUSTSEC-2026-0194 and RUSTSEC-2026-0195 flagged the workspacequick-xml 0.38.4. Both denial-of-service issues are fixed inquick-xml 0.41.0.A
quick-xml 0.39.4copy must temporarily remain because the latestplistandwayland-scannerreleases have not adopted 0.41 yet. Neither retained path accepts attacker-controlled XML at runtime:plistdoes not exercise the affected APIs, andwayland-scannerparses trusted protocol definitions at build time. Compatible upstream bumps are already open in rust-plist#191 and wayland-rs#938.What changed
quick-xmldependency used bycodex-protocolto 0.41.0.Cargo.lockandMODULE.bazel.lock; this also updatesplistto 1.9.0 andwayland-scannerto 0.31.10.cargo-denyandcargo-auditexceptions for the trustedquick-xml 0.39.4paths, with both upstream releases recorded as the removal condition.Testing
cargo deny checkjust test -p codex-protocol(238 tests)just bazel-lock-check