fix(tui): clear completed safety buffering prompt#30490
Merged
Conversation
etraut-openai
approved these changes
Jun 28, 2026
etraut-openai
left a comment
Collaborator
There was a problem hiding this comment.
Change looks good. Approved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The safety-buffering prompt is a modal TUI view, but the normal successful-turn path only hid the running status indicator. If the turn completed while the prompt was open, the stale modal remained over the composer until the user dismissed it or another turn started.
This aligns the TUI with the app behavior: keep the safety notice visible while the turn is active, then remove it when the turn becomes terminal. It also prevents the stale retry action from changing the model and reasoning effort for a future turn after the buffered turn has already completed.
What changed
This is a follow-up to #29919.
How to Test
model/safetyBuffering/updatedwithshowBufferingUi: trueand afasterModel.Targeted automated coverage:
just test -p codex-tui safety_buffering— 4 passed.just test -p codex-tui— 2,951 passed; two unrelated Guardian feature-flag tests failed identically onmainin this environment.The argument-comment lint was also audited manually. The workspace Bazel invocation was blocked by a missing external LLVM
compiler-rtBUILD file, and the packaged per-crate fallback uses a nightly older than the currentsqlxminimum Rust version.