[codex] Classify nested MCP authentication startup errors#30257
Merged
Conversation
Contributor
Author
|
@codex review |
Contributor
|
Codex Review: Didn't find any major issues. Another round soon, please! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Clean refactor! Extracting is_authentication_required_error into the rmcp-client crate makes it reusable. The nested auth classification logic is better as a standalone function. |
xl-openai
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ClientInitializeError::TransportErrorcodex-mcpconsume that classification so the existingreauthenticationRequiredstartup failure reason is emittedWhy
Follow-up to #29877.
RMCP stores streamable HTTP initialization failures inside a dynamic transport error whose payload is not exposed through the standard Rust error source chain. The original
anyhow::Error::chain()check therefore missed the nestedAuthError::AuthorizationRequiredseen during real MCP startup and emittedfailureReason: null.The transport-specific inspection now lives in
codex-rmcp-client, whilecodex-mcpconsumes only the domain-level authentication-required result. This classifier does not distinguish first-time login from reauthentication; the existing auth-state logic remains responsible for that distinction.User impact
When stored MCP OAuth credentials are expired and cannot be refreshed, app clients now receive
failureReason: "reauthenticationRequired"on the failed startup update and can show the reconnect action. First-time login and unrelated startup failures remain unchanged.Validation
just test -p codex-rmcp-client --test streamable_http_oauth_startup identifies_expired_unrefreshable_token_startup_errorjust test -p codex-mcp startup_outcome_error_identifies_authentication_requiredjust test -p codex-mcp mcp_startup_failure_reason_requires_existing_oauth_and_auth_failurecargo build -p codex-cli --bin codexfailureReason: "reauthenticationRequired"just fmt