Skip to content

Relax hooks.json top-level metadata validation - #30229

Merged
charlesgong-openai merged 1 commit into
mainfrom
dev/charlesgong/hooks-json-metadata
Jun 26, 2026
Merged

Relax hooks.json top-level metadata validation#30229
charlesgong-openai merged 1 commit into
mainfrom
dev/charlesgong/hooks-json-metadata

Conversation

@charlesgong-openai

@charlesgong-openai charlesgong-openai commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Allow a top-level description string in hooks.json.
  • Continue rejecting unknown top-level keys and root-level hook events; events must remain under hooks.

Testing

  • just test -p codex-config

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 570af71405

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread codex-rs/config/src/hook_config.rs
Comment thread codex-rs/config/src/hooks_tests.rs Outdated
@charlesgong-openai
charlesgong-openai force-pushed the dev/charlesgong/hooks-json-metadata branch from dffd5b5 to a8a9419 Compare June 26, 2026 11:30
@charlesgong-openai
charlesgong-openai merged commit 2c5bc5e into main Jun 26, 2026
31 checks passed
@charlesgong-openai
charlesgong-openai deleted the dev/charlesgong/hooks-json-metadata branch June 26, 2026 15:24
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 26, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants