[codex] fix CreateThreadParams test initializer - #30198
Merged
Merged
Conversation
anp-oai
marked this pull request as ready for review
June 26, 2026 06:52
anp-oai
enabled auto-merge (squash)
June 26, 2026 07:18
jif-oai
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
selected_capability_rootsin the newattach_in_memory_thread_storetest helpercodex-coretest compilation onmainRoot cause
#30144 added the helper from commit
0c3d0742, whose parent wasc38b2e9b. That branch was based before #29856 addedselected_capability_rootsas a required field onCreateThreadParams.The PR's Rust and Bazel workflows both passed against the stale branch head
0c3d0742. When #30144 was squashed onto newermain, its initializer was integrated alongside the required field from #29856, producingE0063incore/src/session/tests.rs. Because those workflows tested the branch head rather than the integrated merge result, they did not see the version-skew failure before merge.Impact
Any job that compiles the
codex-corelibrary tests fails, which turned the main-branchrust-ci-fullandBazelworkflows red across platforms and blocks unrelated focused core tests. This change only completes the test initializer; it does not alter production behavior or workflow configuration.Validation
just fmtjust test -p codex-core turn_complete_flushes_terminal_event_after_delivery(1 passed, 2909 skipped)git diff --check