Skip to content

[codex] fix CreateThreadParams test initializer - #30198

Merged
anp-oai merged 1 commit into
mainfrom
codex/fix-create-thread-params-capability-roots
Jun 26, 2026
Merged

[codex] fix CreateThreadParams test initializer#30198
anp-oai merged 1 commit into
mainfrom
codex/fix-create-thread-params-capability-roots

Conversation

@anp-oai

@anp-oai anp-oai commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Summary

  • initialize selected_capability_roots in the new attach_in_memory_thread_store test helper
  • restore codex-core test compilation on main

Root cause

#30144 added the helper from commit 0c3d0742, whose parent was c38b2e9b. That branch was based before #29856 added selected_capability_roots as a required field on CreateThreadParams.

The PR's Rust and Bazel workflows both passed against the stale branch head 0c3d0742. When #30144 was squashed onto newer main, its initializer was integrated alongside the required field from #29856, producing E0063 in core/src/session/tests.rs. Because those workflows tested the branch head rather than the integrated merge result, they did not see the version-skew failure before merge.

Impact

Any job that compiles the codex-core library tests fails, which turned the main-branch rust-ci-full and Bazel workflows red across platforms and blocks unrelated focused core tests. This change only completes the test initializer; it does not alter production behavior or workflow configuration.

Validation

  • just fmt
  • just test -p codex-core turn_complete_flushes_terminal_event_after_delivery (1 passed, 2909 skipped)
  • git diff --check

@anp-oai
anp-oai marked this pull request as ready for review June 26, 2026 06:52
@anp-oai
anp-oai requested a review from a team as a code owner June 26, 2026 06:52

@teddywyly-oai teddywyly-oai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anp-oai
anp-oai enabled auto-merge (squash) June 26, 2026 07:18
@anp-oai
anp-oai merged commit 451c0a4 into main Jun 26, 2026
31 checks passed
@anp-oai
anp-oai deleted the codex/fix-create-thread-params-capability-roots branch June 26, 2026 07:47
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 26, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants