[codex] Use managed defaults for TUI threads - #30147
Merged
Merged
Conversation
This was referenced Jun 26, 2026
hefuc-oai
force-pushed
the
codex/managed-new-thread-model-default
branch
from
June 26, 2026 16:56
0f3877f to
0f2bf04
Compare
hefuc-oai
marked this pull request as ready for review
June 26, 2026 17:00
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: de37c67a42
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
hefuc-oai
force-pushed
the
codex/tui-managed-new-thread-defaults
branch
from
June 26, 2026 17:39
dc0b22f to
7f99709
Compare
canvrno-oai
approved these changes
Jun 26, 2026
owenlin0
approved these changes
Jun 26, 2026
hefuc-oai
force-pushed
the
codex/managed-new-thread-model-default
branch
from
June 26, 2026 18:25
0f2bf04 to
4356bf6
Compare
hefuc-oai
force-pushed
the
codex/tui-managed-new-thread-defaults
branch
from
June 26, 2026 18:53
7f99709 to
4bc32d2
Compare
hefuc-oai
enabled auto-merge (squash)
June 26, 2026 19:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
#29683 exposes managed defaults for new-thread model settings through
configRequirements/readwithout applying them server-wide. The TUI is an app-server client, so it should explicitly consume those defaults when it creates a fresh thread.This lets plain
codexstart on the managed model while preserving the existing ability to change model settings within the thread.What changed
requirements.models.newThreadduring TUI app-server bootstrap./newor/clearthreads.fastservice tier to thepriorityrequest value.The application logic lives in a small TUI-only module; app-server
thread/startbehavior remains unchanged for other clients.User experience
codexstarts with the managed new-thread settings./modelor the existing service-tier controls.codex -m <model>continue to win.Validation
just test -p codex-tui managed_new_thread_defaultsjust fix -p codex-tuiDepends on #29683.