[codex] wire process-owned code mode host into core - #30142
Merged
Conversation
jif-oai
approved these changes
Jun 25, 2026
jif-oai
left a comment
Contributor
There was a problem hiding this comment.
Pre-approving but my comment stays valid
| code_mode_service: crate::tools::code_mode::CodeModeService::new(), | ||
| code_mode_service: crate::tools::code_mode::CodeModeService::new( | ||
| if config.features.enabled(Feature::CodeModeHost) { | ||
| Arc::new(codex_code_mode::ProcessOwnedCodeModeSessionProvider::default()) |
Contributor
There was a problem hiding this comment.
This makes the provider session-scoped, so every app-server thread/subagent gets its own host process. Shouldn’t the provider live at ThreadManager/process scope and be shared across sessions? I don't see cases where different sessions would have different code mode backend
cconger
force-pushed
the
cconger/process-owned-session-runtime-4-client
branch
from
June 26, 2026 00:48
06e7c1c to
36f0421
Compare
cconger
force-pushed
the
cconger/code-mode-service-process-host
branch
from
June 26, 2026 01:10
30cafdd to
32513f1
Compare
cconger
force-pushed
the
cconger/process-owned-session-runtime-4-client
branch
from
June 26, 2026 01:10
36f0421 to
c6cae04
Compare
cconger
force-pushed
the
cconger/code-mode-service-process-host
branch
from
June 26, 2026 04:24
32513f1 to
60d23c5
Compare
Base automatically changed from
cconger/process-owned-session-runtime-4-client
to
main
June 26, 2026 06:46
cconger
force-pushed
the
cconger/code-mode-service-process-host
branch
from
June 26, 2026 06:48
60d23c5 to
b98668a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
code_mode_hostfeature flag and selectProcessOwnedCodeModeSessionProviderinCodeModeServicewhen enabledcodex-code-mode-hostbeside the running Codex binary by default while preservingCODEX_CODE_MODE_HOST_PATHas an overrideWhy
This wires the process-owned session client from #30112 into the core service behind an opt-in rollout gate. Packaged Codex installations can place the helper in the same
bindirectory as the main executable without relying onPATH, while development and custom installations can continue to override the helper path.Stack
cconger/process-owned-session-runtime-4-clientValidation
Build
codexandcodex-code-mode-hostCODEX_CODE_MODE_HOST_PATH="$PWD/target/debug/codex-code-mode-host" ./target/debug/codex --enable code_mode_host