ci: narrow Windows test skips - #30134
Merged
Merged
Conversation
anp-oai
marked this pull request as ready for review
June 25, 2026 23:14
Contributor
Author
|
@codex review |
Contributor
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
aibrahim-oai
approved these changes
Jun 25, 2026
sayan-oai
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The Windows cross-build skip used the broad
powershellsubstring, which hid unrelated Windows tests. Narrowing it exposed the same ConPTY Ctrl-C timeout that is breakingmain; that test is not reliable in either cross-built or native Windows Bazel CI yet.What changed
Manual validation
just test-github-scriptsci-windowsandci-windows-crossmainConPTY timeout before the exact CI-only exclusion was applied