Skip to content

ci: narrow Windows test skips - #30134

Merged
anp-oai merged 2 commits into
mainfrom
codex/narrow-powershell-ci-skip
Jun 26, 2026
Merged

ci: narrow Windows test skips#30134
anp-oai merged 2 commits into
mainfrom
codex/narrow-powershell-ci-skip

Conversation

@anp-oai

@anp-oai anp-oai commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Why

The Windows cross-build skip used the broad powershell substring, which hid unrelated Windows tests. Narrowing it exposed the same ConPTY Ctrl-C timeout that is breaking main; that test is not reliable in either cross-built or native Windows Bazel CI yet.

What changed

  • scope the cross-build PowerShell carve-out to the dedicated parser-process test module
  • exclude the exact ConPTY Ctrl-C test from Bazel CI while leaving local Windows runs enabled
  • repeat the exact exclusion in the cross-build config because it replaces the base skip list

Manual validation

  • just test-github-scripts
  • queried the PTY test target under both ci-windows and ci-windows-cross
  • verified the matcher excludes parser-process and ConPTY tests without excluding unrelated PowerShell tests
  • Windows shard 4/4 reproduced the main ConPTY timeout before the exact CI-only exclusion was applied

@anp-oai anp-oai changed the title ci: narrow Windows PowerShell test skip ci: narrow Windows test skips Jun 25, 2026
@anp-oai
anp-oai marked this pull request as ready for review June 25, 2026 23:14
@anp-oai

anp-oai commented Jun 25, 2026

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown
Contributor

Codex Review: Didn't find any major issues. More of your lovely PRs please.

Reviewed commit: 3582604cc7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@anp-oai
anp-oai merged commit 5044062 into main Jun 26, 2026
59 of 61 checks passed
@anp-oai
anp-oai deleted the codex/narrow-powershell-ci-skip branch June 26, 2026 00:01
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 26, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants