[codex] add code-mode host failure supervision hooks - #30110
Merged
Conversation
This was referenced Jun 25, 2026
Base automatically changed from
cconger/process-owned-session-runtime-1-ipc
to
main
June 25, 2026 20:26
cconger
force-pushed
the
cconger/process-owned-session-runtime-2-runtime
branch
from
June 25, 2026 20:32
93c2ba5 to
9dcaccb
Compare
cconger
marked this pull request as ready for review
June 25, 2026 20:38
jif-oai
approved these changes
Jun 25, 2026
| } | ||
| } | ||
| } | ||
| RuntimeEvent::ThreadPanicked => { |
Contributor
There was a problem hiding this comment.
Can we route notification/tool task JoinErrors through the fail-stop handler too? A panic in host.invoke_tool() is currently only logged, leaving the JS promise pending and never
rebuilding the host
cconger
force-pushed
the
cconger/process-owned-session-runtime-2-runtime
branch
from
June 25, 2026 21:49
9dcaccb to
b6b8769
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A process host should be discarded and rebuilt after critical actor or V8 failure, while the existing in-process production path must keep its current cell-error semantics. This change establishes that failure boundary without adding the host process or remote client.
What changed
Follow-up
The V8 panic signal surfaced here should also be consumed by the
InProcessCodeModeSessionmanager in a future change so it can fail the affected cell. This PR intentionally leaves the handler-less in-process behavior unchanged while putting the required panic tracking in place.Stack
This is 2 of 4 in the process-owned code-mode session stack.
mainValidation
just test -p codex-code-mode— 53 passedjust argument-comment-lint -p codex-code-modejust fix -p codex-code-mode