[codex] impl delivery_mode: current time reminders on response boundaries - #30033
Conversation
69ac853 to
06603fb
Compare
19c142f to
74916d0
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 74916d0d9e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if delivery_mode == CurrentTimeReminderDeliveryMode::AfterUserOrToolOutput | ||
| && !is_new_window | ||
| && !follows_user_or_tool_output | ||
| { | ||
| return false; |
There was a problem hiding this comment.
Avoid reading the clock for suppressed reminders
When delivery_mode is AfterUserOrToolOutput and an assistant-only continuation has no pending user/tool-output boundary, this gate correctly returns false, but it runs only after maybe_record_current_time_reminder has already awaited time_provider.current_time() and mapped failures to a fatal turn error. In that ineligible-continuation scenario, an external clock outage can still abort the model request even though no reminder could be injected; split the boundary/window eligibility check so suppressed reminders do not read the clock.
Useful? React with 👍 / 👎.
74916d0 to
c861d4d
Compare
Summary
Why
Training can request reminders only after user or tool-output items while keeping the existing canonical pre-inference history-injection path.
Validation