Skip to content

[codex] add current time reminder delivery mode config - #30031

Merged
rka-oai merged 5 commits into
mainfrom
codex/current-time-reminder-delivery-mode
Jun 25, 2026
Merged

[codex] add current time reminder delivery mode config#30031
rka-oai merged 5 commits into
mainfrom
codex/current-time-reminder-delivery-mode

Conversation

@rka-oai

@rka-oai rka-oai commented Jun 25, 2026

Copy link
Copy Markdown
Contributor
delivery_mode = "any_inference" # default
delivery_mode = "after_user_or_tool_output" # new mode

Validation

  • just test -p codex-core load_config_resolves_current_time_reminder
  • just test -p codex-core lock_contains_prompts_and_materializes_features

@rka-oai
rka-oai marked this pull request as ready for review June 25, 2026 17:32
@rka-oai
rka-oai requested a review from a team as a code owner June 25, 2026 17:32

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 69ac8537ad

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread codex-rs/features/src/feature_configs.rs
Comment thread codex-rs/core/src/config/mod.rs
@rka-oai
rka-oai force-pushed the codex/current-time-reminder-delivery-mode branch from 69ac853 to 06603fb Compare June 25, 2026 18:13
Base automatically changed from codex/current-time-reminder-zero to main June 25, 2026 18:30
@rka-oai
rka-oai enabled auto-merge (squash) June 25, 2026 18:48
@rka-oai
rka-oai merged commit e8d4a1a into main Jun 25, 2026
31 checks passed
@rka-oai
rka-oai deleted the codex/current-time-reminder-delivery-mode branch June 25, 2026 19:06
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 25, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants