[codex] current time reminder interval to be set to 0 - #30029
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 070d3d3b2d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| pub enabled: Option<bool>, | ||
| #[serde(skip_serializing_if = "Option::is_none")] | ||
| #[schemars(range(min = 1))] | ||
| pub reminder_interval_seconds: Option<u64>, |
There was a problem hiding this comment.
Allowing reminder_interval_seconds to deserialize as 0 here exposes the existing scheduler unchanged: CurrentTimeReminderState::take_reminder_due still requires the newly read clock value to be at least the previous delivery time. When clock_source = "external" (or the system clock) moves backward between inference boundaries, a zero interval will skip reminders until the clock catches up, even though zero is intended to request a reminder at every otherwise-eligible boundary. Special-case 0 as always due after the first check/window change instead of relying on elapsed-time comparison.
Useful? React with 👍 / 👎.
| [features.current_time_reminder] | ||
| enabled = true | ||
| reminder_interval_seconds = 4 | ||
| reminder_interval_seconds = 0 |
There was a problem hiding this comment.
The new 0 case is only exercised through config deserialization here; the behavior being introduced is agent scheduling/history injection at inference boundaries, but no core/suite/current_time_reminder integration test covers reminder_interval_seconds = 0. That leaves the user-facing guarantee for zero intervals untested through the path that records reminders into model-visible history, contrary to the repo requirement for agent-logic changes; add an integration test that drives multiple inference boundaries with interval 0.
AGENTS.md reference: AGENTS.md:L112-L118
Useful? React with 👍 / 👎.
A zero interval lets callers request a reminder at every otherwise-eligible inference boundary.
Validation