[codex] allow CCA image generation and web search extensions - #29909
Conversation
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7f36bad543
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| // Core selects this executor per turn using the feature flag or model metadata. | ||
| available: config.model_provider.is_openai(), | ||
| available: config.model_provider.is_openai() | ||
| || config.model_provider.uses_openai_actor_authorization(), |
There was a problem hiding this comment.
Honor disabled image generation for actor providers
When an actor-authorized provider is used with a Responses Lite model and image_generation is disabled in config, this branch still makes the standalone image-generation executor available. Core's Responses Lite visibility path accepts an available image_gen.imagegen executor after provider/model checks without consulting Feature::ImageGeneration, so a configuration intended to disable image generation can still advertise and dispatch it for these providers; gate this availability on the stable feature as well.
AGENTS.md reference: AGENTS.md:L104-L110
Useful? React with 👍 / 👎.
Summary
image_generationandweb_searchfor older models and existing flowsModelProviderInfomodel-provider-infoimage_gen.imagegenandweb.runWhy
CCA uses a provider named
localwithrequires_openai_auth: falseand a non-emptyx-openai-actor-authorizationheader. Core accepts that provider shape, but both extension provider-name gates rejected it; image generation additionally required a Codex-managed login.The standalone paths must coexist with existing builtin tools. New Responses Lite models can receive
image_gen.imagegenandweb.run, while older models continue using builtin tools.Impact
This enables both standalone extensions for CCA once installed downstream, without removing or changing builtin-tool compatibility for older models.
Validation
just test -p codex-core responses_lite_exposes_standalone_tools_for_actor_authorized_providerjust test -p codex-core responses_lite_uses_standalone_web_search_and_image_generationjust test -p codex-core hosted_tools_follow_provider_auth_model_and_config_gatesjust test -p codex-image-generation-extensionjust test -p codex-web-search-extensionjust test -p codex-model-provider-infojust fmtgit diff --check