Skip to content

[codex] allow CCA image generation and web search extensions - #29909

Merged
won-openai merged 6 commits into
mainfrom
won-imagegen-auth-gate
Jun 26, 2026
Merged

[codex] allow CCA image generation and web search extensions#29909
won-openai merged 6 commits into
mainfrom
won-imagegen-auth-gate

Conversation

@won-openai

@won-openai won-openai commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Summary

  • allow the standalone image-generation and web-search extensions for the actor-authorized provider shape used by CCA
  • preserve builtin image_generation and web_search for older models and existing flows
  • keep ordinary non-OpenAI providers excluded from both extensions
  • remove only the image extension local managed-AuthManager requirement that CCA cannot satisfy
  • share actor-authorization detection through ModelProviderInfo
  • keep Core tests focused on routing behavior and cover header-shape edge cases in model-provider-info
  • add a Responses Lite regression that verifies both image_gen.imagegen and web.run

Why

CCA uses a provider named local with requires_openai_auth: false and a non-empty x-openai-actor-authorization header. Core accepts that provider shape, but both extension provider-name gates rejected it; image generation additionally required a Codex-managed login.

The standalone paths must coexist with existing builtin tools. New Responses Lite models can receive image_gen.imagegen and web.run, while older models continue using builtin tools.

Impact

This enables both standalone extensions for CCA once installed downstream, without removing or changing builtin-tool compatibility for older models.

Validation

  • just test -p codex-core responses_lite_exposes_standalone_tools_for_actor_authorized_provider
  • just test -p codex-core responses_lite_uses_standalone_web_search_and_image_generation
  • just test -p codex-core hosted_tools_follow_provider_auth_model_and_config_gates
  • just test -p codex-image-generation-extension
  • just test -p codex-web-search-extension
  • just test -p codex-model-provider-info
  • just fmt
  • git diff --check

@won-openai won-openai changed the title [codex] let Core gate image generation extension [codex] allow CCA image generation extension Jun 24, 2026
@won-openai won-openai changed the title [codex] allow CCA image generation extension [codex] use standalone image generation for CCA Jun 24, 2026
@won-openai won-openai changed the title [codex] use standalone image generation for CCA [codex] allow CCA image generation extension Jun 24, 2026
@won-openai

Copy link
Copy Markdown
Contributor Author

@codex review

@won-openai won-openai changed the title [codex] allow CCA image generation extension [codex] allow CCA image generation and web search extensions Jun 24, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7f36bad543

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

// Core selects this executor per turn using the feature flag or model metadata.
available: config.model_provider.is_openai(),
available: config.model_provider.is_openai()
|| config.model_provider.uses_openai_actor_authorization(),

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Honor disabled image generation for actor providers

When an actor-authorized provider is used with a Responses Lite model and image_generation is disabled in config, this branch still makes the standalone image-generation executor available. Core's Responses Lite visibility path accepts an available image_gen.imagegen executor after provider/model checks without consulting Feature::ImageGeneration, so a configuration intended to disable image generation can still advertise and dispatch it for these providers; gate this availability on the stable feature as well.

AGENTS.md reference: AGENTS.md:L104-L110

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this true?

Comment thread codex-rs/core/tests/suite/responses_lite.rs Outdated
@won-openai
won-openai marked this pull request as ready for review June 26, 2026 01:34
@won-openai
won-openai requested a review from a team as a code owner June 26, 2026 01:34
@won-openai
won-openai merged commit 0d4351c into main Jun 26, 2026
46 of 47 checks passed
@won-openai
won-openai deleted the won-imagegen-auth-gate branch June 26, 2026 01:34
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 26, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants