Skip to content

Fix environment skill discovery after merge - #29887

Merged
jif-oai merged 1 commit into
mainfrom
jif/fix-environment-skill-discovery-merge
Jun 24, 2026
Merged

Fix environment skill discovery after merge#29887
jif-oai merged 1 commit into
mainfrom
jif/fix-environment-skill-discovery-merge

Conversation

@jif-oai

@jif-oai jif-oai commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Why

The merge of #29831 with the new fs/walk environment discovery path left three SkillFileDiscovery initializers without the new namespace fields. This makes codex-core-skills fail to compile and breaks CI for every PR based on current main.

What changed

  • collect plugin roots from the directory entries already returned by fs/walk
  • keep the selected root as the namespace fallback
  • initialize empty discovery results with empty namespace sets

This preserves the bounded fs/walk implementation while restoring the namespace caching added by #29831.

@jif-oai
jif-oai merged commit 8a6a34b into main Jun 24, 2026
27 of 29 checks passed
@jif-oai
jif-oai deleted the jif/fix-environment-skill-discovery-merge branch June 24, 2026 18:08
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 24, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant