[2/3] core: persist world state in rollouts - #29835
Merged
Merged
Conversation
sayan-oai
marked this pull request as ready for review
June 24, 2026 19:48
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7af2b6f44a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
sayan-oai
force-pushed
the
codex/world-state-snapshots
branch
from
June 25, 2026 00:36
46d2d19 to
27dac17
Compare
sayan-oai
force-pushed
the
codex/persist-world-state
branch
from
June 25, 2026 00:36
7af2b6f to
f2750c1
Compare
sayan-oai
force-pushed
the
codex/persist-world-state
branch
from
June 25, 2026 01:11
f2750c1 to
922aac2
Compare
sayan-oai
force-pushed
the
codex/persist-world-state
branch
from
June 25, 2026 02:28
922aac2 to
4ed9d3a
Compare
sayan-oai
added a commit
that referenced
this pull request
Jun 25, 2026
sayan-oai
force-pushed
the
codex/persist-world-state
branch
from
June 25, 2026 02:58
8218445 to
7667ec5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
WorldStatecurrently remembers its model-visible diff baseline only in memory. That leaves no durable source for restoring the exact baseline after resume, fork, rollback, or compaction.This is the second PR in the WorldState persistence stack, built on #29833 and following #29249. It records durable state transitions; the next PR will replay them during rollout reconstruction.
What
world_staterollout item containing either a full snapshot or an RFC 7386 JSON Merge Patch.Older binaries read rollout lines independently, so they skip the unknown
world_staterecords while retaining the rest of the thread.Testing
just test -p codex-core snapshot_merge_patch_changes_and_removes_nested_valuesjust test -p codex-core world_state_baseline_deduplicates_until_history_is_replacedjust test -p codex-core deferred_executor_compaction_preserves_then_updates_environment_oncejust test -p codex-protocoljust test -p codex-rolloutjust test -p codex-statejust test -p codex-thread-storejust test -p codex-app-server-protocol