test: use automatic environments in app-server integration tests - #29789
Merged
Conversation
anp-oai
force-pushed
the
codex/migrate-app-server-auto-env
branch
from
June 24, 2026 04:15
e8319fa to
9b16dec
Compare
anp-oai
force-pushed
the
codex/app-server-wine-exec-prefactor
branch
from
June 24, 2026 04:48
1500e21 to
fdfe625
Compare
anp-oai
force-pushed
the
codex/migrate-app-server-auto-env
branch
from
June 24, 2026 04:48
9b16dec to
93f59ba
Compare
anp-oai
marked this pull request as ready for review
June 24, 2026 04:52
Contributor
Author
|
@codex review |
sayan-oai
approved these changes
Jun 24, 2026
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 93f59ba3de
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
anp-oai
force-pushed
the
codex/app-server-wine-exec-prefactor
branch
from
June 24, 2026 05:10
fdfe625 to
d7d7af6
Compare
anp-oai
force-pushed
the
codex/migrate-app-server-auto-env
branch
from
June 24, 2026 05:31
93f59ba to
029b348
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Topology-neutral app-server integration tests should exercise automatic environment selection so the same setup covers local and remote executors.
What
Migrate eligible tests to
TestAppServer::new_with_auto_env()andsend_thread_start_request_with_auto_env(). Leave explicit-topology tests unchanged, and skip the request-permissions case on Windows with a TODO for cross-platform tool routing.Validation
just test -p codex-app-serverbazel test //codex-rs/app-server:app-server-all-wine-exec-test --test_output=errorsStacked on #29788.