test: add app-server auto environment helper - #29746
Merged
Merged
Conversation
anp-oai
marked this pull request as ready for review
June 24, 2026 00:14
Contributor
Author
|
@codex review |
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f3f3ba3abe
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
pakrym-oai
approved these changes
Jun 24, 2026
anp-oai
force-pushed
the
codex/app-server-auto-env
branch
from
June 24, 2026 00:48
f3f3ba3 to
ad6bb9b
Compare
anp-oai
enabled auto-merge (squash)
June 24, 2026 00:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Start moving towards app-server tests defaulting to running against remote & foreign OS executors. To do so we need a point of indirection similar to core integration tests'
build_with_auto_env, but with the flexibility of letting tests control environment registration if they need to.What
This adds:
TestAppServer::new_with_auto_env()for constructing an app server with a default environment defined by the test runner (e.g. bazel)TestAppServer::auto_env_params()for tests to easily acquire turn env params tailored to the automatic environmentTestAppServer::send_thread_start_request_with_auto_env()to make it easy for tests to start a thread using the automatic environmentThe above methods all fail if the test calling them has set up an environment where the automatic environment configuration conflicts with test-created state.
Validation
Adds a couple of basic smoke tests to the app-server test suite. Follow-ups will migrate more tests to use it.