core: add wait_for_environment for starting environments - #29745
Merged
Conversation
pakrym-oai
reviewed
Jun 23, 2026
pakrym-oai
reviewed
Jun 23, 2026
pakrym-oai
reviewed
Jun 23, 2026
pakrym-oai
approved these changes
Jun 23, 2026
sayan-oai
enabled auto-merge (squash)
June 24, 2026 00:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
With
DeferredExecutor, a sampling request can begin while an environment is still starting. The model can see that pending state, but needs a way to wait for the environment within the same turn before continuing.Environment startup is owned by Core, so the wait tool should use the same request-frozen
StepContextthat advertised the starting environment. This keeps tool registration and execution tied to the exact startup operation the model saw, even if live thread state later changes.Supersedes #29735.
What
wait_for_environmentwhen the currentStepContextcontains starting environmentsStartingTurnEnvironmentshared resolution and return a bounded ready or failed resultTesting
just test -p codex-core deferred_executor_