-
Notifications
You must be signed in to change notification settings - Fork 15.4k
[codex] rename rollout budget error to session budget error #29744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1690,7 +1690,7 @@ pub enum NonSteerableTurnKind { | |
| #[ts(rename_all = "snake_case")] | ||
| pub enum CodexErrorInfo { | ||
| ContextWindowExceeded, | ||
| RolloutBudgetExceeded, | ||
| SessionBudgetExceeded, | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
When resuming or reading a rollout written before this rename, the persisted AGENTS.md reference: AGENTS.md:L103-L111 Useful? React with 👍 / 👎. |
||
| UsageLimitExceeded, | ||
| ServerOverloaded, | ||
| CyberPolicy, | ||
|
|
@@ -1728,7 +1728,7 @@ impl CodexErrorInfo { | |
| match self { | ||
| Self::ThreadRollbackFailed | Self::ActiveTurnNotSteerable { .. } => false, | ||
| Self::ContextWindowExceeded | ||
| | Self::RolloutBudgetExceeded | ||
| | Self::SessionBudgetExceeded | ||
| | Self::UsageLimitExceeded | ||
| | Self::ServerOverloaded | ||
| | Self::CyberPolicy | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For app-server v2 clients that already switch on the documented
codexErrorInfostring, this changes the server-emitted value fromrolloutBudgetExceededtosessionBudgetExceeded; those clients will miss the budget-exhaustion classification even though the rest of theerror/turnpayload shape is unchanged. If this is meant to be a Rust naming cleanup, keep the old wire spelling with a targeted serde rename (or otherwise version the API change) so existing app-server consumers continue to classify this error.AGENTS.md reference: AGENTS.md:L103-L111
Useful? React with 👍 / 👎.